Skip to content

#CNV-35102: new disaster recovery section #70454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2024
Merged

#CNV-35102: new disaster recovery section #70454

merged 1 commit into from
Feb 8, 2024

Conversation

sabrinajess
Copy link
Contributor

@sabrinajess sabrinajess commented Jan 17, 2024 •
edited
Loading

Version(s): 4.15+

Issue: CNV-35102

Link to docs preview: https://70454--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/backup_restore/virt-disaster-recovery

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-35102 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: CNV-35102

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-35102 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: CNV-35102

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 17, 2024 •
edited
Loading

🤖 Thu Feb 08 20:04:11 - Prow CI generated the docs preview: https://70454--ocpdocs-pr.netlify.app

@sabrinajess
Copy link
Contributor Author

/retest

@sabrinajess sabrinajess reopened this Jan 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2024 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-35102 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: CNV-35102

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sabrinajess sabrinajess force-pushed the CNV-35102 branch 2 times, most recently from b0385d0 to 05938f6 Compare January 18, 2024 15:19
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2024 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-35102 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: CNV-35102

Link to docs preview: https://70454--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/backup_restore/virt-disaster-recovery

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sabrinajess
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 2, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented Feb 2, 2024

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 2, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented Feb 2, 2024

/remove-label peer-review-in-progress

/label peer-review-done

Hi @sabrinajess . Nice work on the PR. LGTM. The embedded link for the Metropolitan Disaster Recovery (Metro-DR) heading might be missed by screen readers, so consider adding a link to the end of the section.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 2, 2024
@sabrinajess sabrinajess force-pushed the CNV-35102 branch 5 times, most recently from 5df0ce4 to 88e48f8 Compare February 7, 2024 18:34
kgoldbla
kgoldbla reviewed Feb 8, 2024
View reviewed changes
@sabrinajess sabrinajess force-pushed the CNV-35102 branch 2 times, most recently from 5d0a513 to 9a177ba Compare February 8, 2024 15:54
kgoldbla
kgoldbla reviewed Feb 8, 2024
View reviewed changes
Copy link

@kgoldbla kgoldbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-35102 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15+

Issue: CNV-35102

Link to docs preview: https://70454--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/backup_restore/virt-disaster-recovery

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sabrinajess
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 8, 2024
@adellape adellape self-assigned this Feb 8, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 8, 2024
adellape
adellape reviewed Feb 8, 2024
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 8, 2024

@sabrinajess: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adellape adellape merged commit 5a9de00 into openshift:main Feb 8, 2024
@adellape adellape added this to the Planned for 4.15 GA milestone Feb 8, 2024
@adellape
Copy link
Contributor

adellape commented Feb 8, 2024

/cherrypick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 8, 2024
Merged
@openshift-cherrypick-robot
Copy link

@adellape: new pull request created: #71395

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adellape adellape added branch/enterprise-4.15 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgoldbla kgoldbla kgoldbla left review comments

@adellape adellape adellape approved these changes

Assignees

@adellape adellape

Labels
branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.15 GA
Development

Successfully merging this pull request may close these issues.
7 participants
@sabrinajess @openshift-ci-robot @ocpdocs-previewbot @dfitzmau @adellape @openshift-cherrypick-robot @kgoldbla